Avoid having to go back to the UI thread in the navbar code #73681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@ToddGrun ptal |
CyrusNajmabadi
commented
May 24, 2024
| @@ -161,26 +183,6 @@ void IDisposable.Dispose() | |||
| _cancellationTokenSource.Cancel(); | |||
| } | |||
|
|
|||
| private void Pause() | |||
CyrusNajmabadi
commented
May 24, 2024
|
|
||
| // Cancel any in flight work. We're on the UI thread, so we know this is the latest position of the user, and that | ||
| // this should supersede any other selection work items. | ||
| _selectItemQueue.AddWork(caretPoint.Value, cancelExistingWork: true); |
There was a problem hiding this comment.
we now grab the caret and pass it along.
CyrusNajmabadi
commented
May 24, 2024
| { | ||
| // Switch to the UI so we can determine where the user is and determine the state the last time we updated | ||
| // the UI. | ||
| await _threadingContext.JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken).NoThrowAwaitable(); |
There was a problem hiding this comment.
no more need to switch here.
CyrusNajmabadi
commented
May 24, 2024
|
|
||
| GetProjectItems(out var projectItems, out var selectedProjectItem); | ||
| var (projectItems, selectedProjectItem) = GetProjectItems(); | ||
| if (Equals(model, lastPresentedInfo.model) && | ||
| Equals(currentSelectedItem, lastPresentedInfo.selectedInfo) && | ||
| Equals(selectedProjectItem, lastPresentedInfo.selectedProjectItem) && |
There was a problem hiding this comment.
in the common case (caret moving in the same member) we will bail out immediately, and not hit hte ui thread. we only need to go back if we're actually updating the UI thread.
CyrusNajmabadi
commented
May 24, 2024
| // Once we've computed and selected the latest navbar items, pause ourselves if we're no longer visible. | ||
| // That way we don't consume any machine resources that the user won't even notice. | ||
| if (_visibilityTracker?.IsVisible(_subjectBuffer) is false) | ||
| Pause(); |
There was a problem hiding this comment.
this was intentionally removed. we don't need to check this here for visibility. We just listen for visbility changes directly and pause/unpause us accordingly.
ToddGrun
reviewed
May 24, 2024
| language: d.Project.Language)).OrderBy(projectItem => projectItem.Text)]; | ||
| language: d.Project.Language)) | ||
| .OrderBy(projectItem => projectItem.Text) | ||
| .ToImmutableArray(); |
ToddGrun
reviewed
May 24, 2024
| Pause(); | ||
| } | ||
| // Make a task that waits indefinitely, or until the cancellation token is signaled. | ||
| var cancellationTriggeredTask = Task.Delay(-1, cancellationToken); |
|
I'm very happy with this change. I feel like mainthread switches are an area that we've neglected in our perf efforts. |
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.